Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

break url to pdf/ps #409

Closed
RekGRpth opened this issue Jan 15, 2021 · 3 comments
Closed

break url to pdf/ps #409

RekGRpth opened this issue Jan 15, 2021 · 3 comments
Assignees
Labels
bug Something isn't working priority-high
Milestone

Comments

@RekGRpth
Copy link

this change in commit 580a1e5

 
   DEBUG_printf(("file_find: \"%s\" not in web cache of %d files...\n", s, (int)web_files));
@@ -725,7 +725,13 @@ file_find(const char *path,		/* I - Path "dir;dir;dir" */
     }
   }
 
-  return (file_find_check(s));
+  if (file_find_check(s))
+  {
+    strlcpy(filename, s, sizeof(filename));
+    return (filename);
+  }
+  else
+    return (NULL);
 }
 
 

break url to pdf/ps

@michaelrsweet
Copy link
Owner

@RekGRpth Can you provide an example where this breaks? This change was needed to fix a value scoping issue.

@michaelrsweet michaelrsweet self-assigned this Jan 15, 2021
@michaelrsweet michaelrsweet added the investigating Investigating the issue label Jan 15, 2021
@RekGRpth
Copy link
Author

RekGRpth commented Jan 15, 2021

this does not work

htmldoc --bodyfont Sans --charset utf-8 --webpage -f test.pdf --header . --footer . "https://google.com"
ERR-01: Success (https://google.com)
ERR005: Unable to find "https://google.com"...
HTMLDOC Version 1.9.12 Copyright 2011-2020 by Michael R Sweet.
...

michaelrsweet added a commit that referenced this issue Jan 23, 2021
Fix URL regression caused by Coverity changes (Issue #409)
@michaelrsweet michaelrsweet added bug Something isn't working priority-high and removed investigating Investigating the issue labels Jan 23, 2021
@michaelrsweet michaelrsweet added this to the Stable milestone Jan 23, 2021
@michaelrsweet
Copy link
Owner

[master 008861d] Fix crash bug with data: URIs (Issue #410)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working priority-high
Projects
None yet
Development

No branches or pull requests

2 participants