Fix editor history selecting wrong file

Cause: EditHistory calls MultipleEdit with arguments that are passed by reference and will be implicitly substituted in FEditHistories.push_back.
michaellukashov · Apr 9, 2024 · 311e989 · 311e989
1 parent 355c2e0
commit 311e989
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/src/NetBox/WinSCPFileSystem.cpp b/src/NetBox/WinSCPFileSystem.cpp
@@ -4113,8 +4113,8 @@ void TWinSCPFileSystem::MultipleEdit()
   }
 }
 
-void TWinSCPFileSystem::MultipleEdit(const UnicodeString & Directory,
-  const UnicodeString & AFileName, const TRemoteFile * AFile)
+void TWinSCPFileSystem::MultipleEdit(const UnicodeString Directory,
+  const UnicodeString AFileName, const TRemoteFile * AFile)
 {
   DebugAssert(AFile);
   TEditHistory EditHistory;

diff --git a/src/NetBox/WinSCPFileSystem.h b/src/NetBox/WinSCPFileSystem.h
@@ -215,7 +215,7 @@ class TWinSCPFileSystem final : public TCustomFarFileSystem
       const UnicodeString & RealFileName, UnicodeString & DestPath);
   void LogAuthentication(TTerminal * Terminal, const UnicodeString & Msg);
   void MultipleEdit();
-  void MultipleEdit(const UnicodeString & Directory, const UnicodeString & AFileName, const TRemoteFile * AFile);
+  void MultipleEdit(const UnicodeString Directory, const UnicodeString AFileName, const TRemoteFile * AFile);
   void EditViewCopyParam(TCopyParamType & CopyParam);
   bool SynchronizeBrowsing(const UnicodeString & NewPath);
   bool IsEditHistoryEmpty() const;