jenkinsClassnamePrefix option #94
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This option allows to group tests under the package name. For example if jenkinsClassnamePrefix = "cypress.". Then all cypress tests would be placed under the cypress package. The dot will work as a classname separator. It is very useful for monorepos where user can have multiple test cases/runners etc. Right now, when there is no package everything land in (root) which is not very useful.
nikglavin
reviewed
Dec 17, 2019
| debug('Building jenkins classname for', test); | ||
| var parent = test.parent; | ||
| var titles = []; | ||
| while (parent) { | ||
| parent.title && titles.unshift(parent.title); | ||
| parent = parent.parent; | ||
| } | ||
| return titles.join('.'); | ||
| return options.jenkinsClassnamePrefix + titles.join('.'); |
There was a problem hiding this comment.
It would be good to use options.suiteTitleSeparatedBy rather than having to explicitly add it in options.jenkinsClassnamePrefix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This option allows to group tests under the package name. For example if
jenkinsClassnamePrefix = "cypress.". Then all cypress tests would be placed under thecypresspackage. The dot (.) will work as a classname separator.It is very useful for monorepos where user can have multiple test cases/runners etc. Right now, when there is no package everything land in (root) which is not very useful.
Example:
Now (without the prefix option) - all test cases with single classname (without dot) will land under (root)
With prefix we can group tests together:
