Change *http.Transport to http.RoundTripper #123
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://golang.org/pkg/net/http/#RoundTripper
This will allow anyone to pass through custom transport implementations, such as logging transport we use over in Terraform:
https://github.com/hashicorp/terraform/blob/master/helper/logging/transport.go
*http.Transport
implements this interface so this should not break anything.I tried running tests via
make test
but they mostly fail (on master) for me. It may be just different environment, I don't know - I hope my changes didn't break anything. 🤞