Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Any reason to pindown upper version in requirements.txt #83

Open
idlesign opened this issue Feb 15, 2022 · 1 comment · May be fixed by #84
Open

Any reason to pindown upper version in requirements.txt #83

idlesign opened this issue Feb 15, 2022 · 1 comment · May be fixed by #84

Comments

@idlesign
Copy link

idlesign commented Feb 15, 2022 •
edited
Loading

Hi,

Since lassie is a library, limiting upper versions for dependencies as in

requests>=2.18.4,<3.0.0
beautifulsoup4>=4.9.0,<4.10.0

can lead to conflicts for software using it, e.g. on pip install:

The conflict is caused by:
    The user requested beautifulsoup4==4.10.0
    lassie 0.11.11 depends on beautifulsoup4<4.10.0 and >=4.9.0

Is there any reason for the pindown?
idlesign referenced this issue in idlesign/pythonz Feb 15, 2022
@idlesign
Обновление зависимостей.
534b03e
@michaelhelmick
Copy link
Owner

👋 no reason! Feel free to open a PR unpinning minors. Please keep it at least pinned to major release.

idlesign added a commit to idlesign/lassie that referenced this issue Feb 28, 2022
@idlesign
Pindown beautifulsoup4 to major version
6c31a30 
Closes michaelhelmick#83
@idlesign idlesign linked a pull request Feb 28, 2022 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Pindown beautifulsoup4 to major version idlesign/lassie
2 participants
@idlesign @michaelhelmick