Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecation notices with Twig 3.12 #39

Open
basdenooijer opened this issue Sep 11, 2024 · 1 comment
Open

Deprecation notices with Twig 3.12 #39

basdenooijer opened this issue Sep 11, 2024 · 1 comment

Comments

@basdenooijer
Copy link

Using this bundle with Twig version 3.12 or higher will trigger the deprecation Twig Filter "spaceless" is deprecated for the templates Resources/views/microdata.html.twig and Resources/views/json-ld.html.twig.

This happens even with a different template configured. As a workaround we now override the bundle template as described in the docs in the folder <your-project>/templates/bundles/WhiteOctoberBreadcrumbsBundle.

I considered creating a PR to fix this, but I am not sure if it should just be removed or replaced with another solution to keep backwards compatibility.

@mhujer
Copy link
Owner

mhujer commented Sep 11, 2024

@basdenooijer Based on the arguments in twigphp/Twig#4236 I think it can be removed.

basdenooijer added a commit to basdenooijer/BreadcrumbsBundle that referenced this issue Sep 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants