Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

set individual deadline when matching udp connection #249

Merged
merged 4 commits into from
Oct 12, 2024

Conversation

WeidiDeng
Copy link
Contributor

fix 247.

@WeidiDeng WeidiDeng changed the title do not set read deadline when matching udp connection set individual deadline when matching udp connection Oct 9, 2024
@WeidiDeng
Copy link
Contributor Author

An actual read deadline is implemented using timers.

@vnxme
Copy link
Collaborator

vnxme commented Oct 9, 2024

Wow, thank you for the additional effort you've contributed to this issue!

I will re-test the OpenVPN matcher and confirm if your extended fix works with it as fine as the original version.

Update: the extended fix works fine for me in DNS and OpenVPN tests.

Copy link
Owner

@mholt mholt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much for the patch, and for the verification @vnxme !

@mholt mholt merged commit 31af7cd into mholt:master Oct 12, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

UDP gets blocked after any unsuccessful matching
3 participants