Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add SetIf and DeleteIf methods. #6

Merged
merged 1 commit into from
Nov 7, 2023

Conversation

chirino
Copy link
Contributor

@chirino chirino commented Nov 5, 2023

These methods allow you to lazy create/initialize values and decide if the values should be set or deleted while the map shard is locked.

@chirino chirino force-pushed the add-loadif-methods branch from a52b5e3 to b6b42fb Compare November 5, 2023 16:17
@mhmtszr
Copy link
Owner

mhmtszr commented Nov 6, 2023

@chirino thanks for the contribution, could you please fix the golang-ci lint errors?

These methods allow you to lazy create/initialize values and decide if 
the values should be set or deleted while the map shard is locked.

Signed-off-by: Hiram Chirino <hiram@hiramchirino.com>
@chirino chirino force-pushed the add-loadif-methods branch from b6b42fb to 4abf628 Compare November 6, 2023 14:07
@chirino
Copy link
Contributor Author

chirino commented Nov 6, 2023

@mhmtszr I think this new version should pass the linter.

@mhmtszr mhmtszr merged commit b6304c6 into mhmtszr:master Nov 7, 2023
1 check passed
@mhmtszr
Copy link
Owner

mhmtszr commented Nov 7, 2023

@chirino thanks, I merged and deployed it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants