Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change path from Resources to resources #41

Merged
merged 1 commit into from
Mar 24, 2024

Conversation

philipnjuguna66
Copy link
Contributor

In Laravel modules version 10, the resource paths are in lowercase. Therefore, this pull request adjusts the resource paths from uppercase to lowercase to align with the convention used in version 10 of Laravel modules.

@dcblogdev
Copy link
Contributor

hmm the trouble is it's not strictly set that way, anyone can change the paths from upper to lowercase as they want. Seems to work fine in either case.

I don't think this is needed.

Here I have 2 modules one with Resources and one with resources both work without any changes

Screenshot 2024-03-18 at 18 10 00

Blog
Screenshot 2024-03-18 at 18 12 08

Docs
Screenshot 2024-03-18 at 18 12 48

@Filefabrik
Copy link

@philipnjuguna66

while php artisan vendor:publish --tag=modules-livewire-config
have a look in Laravel-Root1 '/config/modules-livewire.php'

` /*
|--------------------------------------------------------------------------
| View Path
|--------------------------------------------------------------------------
|
*/

'view' => 'Resources/views/livewire',

`
change to

` /*
|--------------------------------------------------------------------------
| View Path
|--------------------------------------------------------------------------
| Lover-Cased :))
*/

'view' => 'resources/views/livewire',

`

That should work

@mhmiton mhmiton merged commit 144e51e into mhmiton:main Mar 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants