Add sidekiq_option for on-conflict-reschedule perform_in time #813
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mgmarlow
force-pushed
the
on-conflict-reschedule-perform-in-option
branch
from
4f5ca29
to
0b10ae2
Compare
Add schedule_in sidekiq job option to customize the on-conflict-reschedule duration of 5 seconds. The default remains 5 seconds if no schedule_in is provided.
mgmarlow
force-pushed
the
on-conflict-reschedule-perform-in-option
branch
from
0b10ae2
to
971d170
Compare
|
Thank you for contributing! That's a great addition to the gem |
Happy to help! I was taking a look at the build failures but I don't think they're related to this PR, unless I'm reading something wrong: Let me know if you'd like me to make any updates to this PR. |
mhenrixon
approved these changes
Nov 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add schedule_in sidekiq job option to customize the on-conflict-reschedule duration of 5 seconds. The default remains 5 seconds if no schedule_in is provided.
In my particular use-case for on-conflict-reschedule, the jobs that I'm rescheduling have rather long processing times (eg minutes instead of seconds). The default
perform_inof 5 seconds causes a lot of churn in the sidekiq scheduler, I'd prefer to schedule conflicts out another minute or so rather than attempting after a few seconds.