fix: while_executing should not invoke conflict strategy when the job was successfully executed.
#806
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leandrogoe
changed the title
while_executing should not invoke conflict strategy when it was successfully executed.while_executing should not invoke conflict strategy when the job was successfully executed.
leandrogoe
changed the title
while_executing should not invoke conflict strategy when the job was successfully executed.while_executing should not invoke conflict strategy when the job was successfully executed.
mhenrixon
approved these changes
Aug 19, 2023
auto-merge was automatically disabled
August 21, 2023 15:06
Head branch was pushed to by a user without write access
auto-merge was automatically disabled
August 28, 2023 14:50
Head branch was pushed to by a user without write access
|
There were some linting failures unrelated with the files I've touched, not sure why. I've corrected those as well now to make sure the pipeline passes. |
|
Hi @mhenrixon and @leandrogoe , was this fix supposed to go to the |
|
@sfavrinlumint I made it for the 7.1 because I was using 7.1.30 and hence needed a fix in that branch. Another PR will be needed for 8.X |
cuzik
added a commit
to cuzik/sidekiq-unique-jobs
that referenced
this pull request
Sep 21, 2023
|
Are there plans to publish a release for this fix? |
mhenrixon
pushed a commit
to cuzik/sidekiq-unique-jobs
that referenced
this pull request
Nov 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the
WhileExecutinglock only works properly if the middleware chain downstream returns a truthy value.When a falsey value is returned, the on-conflict strategy is invoked, which shouldn't happen.
Originally reported here.