Fixing reschedule when using a non default queue #679
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a job uses a non default queue in it's
sidekiq_options
, theon_conflict
strategy still enqueues the job into thedefault
queue even though, the queue information is available initem
.The MR fixes this by calling
set(queue: item['queue'].to_sym)
beforeperform_in
in reschedule. It assumes thatitem
always contains queue.