Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Give user full control over adding middleware #566

Merged
merged 4 commits into from
Jan 20, 2021
Merged

Give user full control over adding middleware #566

merged 4 commits into from
Jan 20, 2021

Conversation

mhenrixon
Copy link
Owner

Close #564

This prevents the middleware being added in the wrong place while removing some complexity from the gem.

Making a decision on where to add the middleware became almost impossible. Give the user full controll, update the example configuration in the rails app and document all the known cases.

This prevents the middleware being added in the wrong place while removing some complexity from the gem.

Making a decision on where to add the middleware became almost impossible. Give the user full controll, update the example configuration in the rails app and document all the known cases.
@mhenrixon mhenrixon added this to the V7.0 milestone Jan 20, 2021
@mhenrixon mhenrixon self-assigned this Jan 20, 2021
@mhenrixon mhenrixon merged commit b5565ba into master Jan 20, 2021
@delete-merged-branch delete-merged-branch bot deleted the issue-564 branch January 20, 2021 09:11
@gchan gchan mentioned this pull request Feb 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rejected jobs are still displayed as 'Queued' with gem 'sidekiq-status' on /sidekiq/statuses
1 participant