Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename lock_args to lock_args_method #551

Merged
merged 8 commits into from
Nov 3, 2020
Merged

Rename lock_args to lock_args_method #551

merged 8 commits into from
Nov 3, 2020

Commits on Nov 2, 2020

  1. Fix lock_args not being set

    @mhenrixon
    mhenrixon committed Nov 2, 2020
    Configuration menu
    Copy the full SHA
    6cb1ea3 View commit details
    Browse the repository at this point in the history

  2. Mandatory rubocop commit

    @mhenrixon
    mhenrixon committed Nov 2, 2020
    Configuration menu
    Copy the full SHA
    8e92354 View commit details
    Browse the repository at this point in the history

  3. Make lock_args idempotent 

    Otherwise, lock_args are redefined on every run both from server and client.
    @mhenrixon
    mhenrixon committed Nov 2, 2020
    Configuration menu
    Copy the full SHA
    fe81ed8 View commit details
    Browse the repository at this point in the history

  4. Add more to post-install

    @mhenrixon
    mhenrixon committed Nov 2, 2020
    Configuration menu
    Copy the full SHA
    a60b80b View commit details
    Browse the repository at this point in the history

  5. Mandatory rubocop commit

    @mhenrixon
    mhenrixon committed Nov 2, 2020
    Configuration menu
    Copy the full SHA
    dbdddaa View commit details
    Browse the repository at this point in the history

  6. Add regression tests and fix rubocop violations

    @mhenrixon
    mhenrixon committed Nov 2, 2020
    Configuration menu
    Copy the full SHA
    e3a8ec6 View commit details
    Browse the repository at this point in the history

  7. Add lock_args => lock_args_method to deprecation 

    This should allow people who use the worker validation to catch this.
    @mhenrixon
    mhenrixon committed Nov 2, 2020
    Configuration menu
    Copy the full SHA
    a79697f View commit details
    Browse the repository at this point in the history

  8. Adds missing coverage

    @mhenrixon
    mhenrixon committed Nov 2, 2020
    Configuration menu
    Copy the full SHA
    4b025d0 View commit details
    Browse the repository at this point in the history