Close #359 #364
Merged
Close #359 #364
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jwg2s
approved these changes
Jan 10, 2019
| @@ -28,5 +28,7 @@ else | |||
| redis.call('DEL', unique_digest) -- TODO: Legacy support (Remove in v6.1) | |||
| end | |||
|
|
|||
| return redis.call('LPUSH', available_key, token) | |||
| local count = redis.call('LPUSH', available_key, token) | |||
| redis.call('EXPIRE', available_key, 5) | |||
There was a problem hiding this comment.
Curious as to why you picked 5 seconds here. Worth making a constant?
There was a problem hiding this comment.
No particular reason, do you think 5 is too high? Too low? I mean the key doesn't really do anything except signal to locks that are waiting that the key is now available.
There was a problem hiding this comment.
Nah was just curious - sort of a magic number if you're reading that code without context
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should fix and close #359