Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Code smells #275

Merged
merged 20 commits into from
Jun 21, 2018
Merged

Code smells #275

merged 20 commits into from
Jun 21, 2018

Commits on Jun 19, 2018

  1. Reduce the complexity of utils

    @mhenrixon
    mhenrixon committed Jun 19, 2018
    Configuration menu
    Copy the full SHA
    303377e View commit details
    Browse the repository at this point in the history

  2. Style violations

    @mhenrixon
    mhenrixon committed Jun 19, 2018
    Configuration menu
    Copy the full SHA
    89b6667 View commit details
    Browse the repository at this point in the history

Commits on Jun 20, 2018

  1. Introduce a logging module

    @mhenrixon
    mhenrixon committed Jun 20, 2018
    Configuration menu
    Copy the full SHA
    c3a1c7f View commit details
    Browse the repository at this point in the history

  2. Use a specific unique_key helper method

    @mhenrixon
    mhenrixon committed Jun 20, 2018
    Configuration menu
    Copy the full SHA
    15972e7 View commit details
    Browse the repository at this point in the history

  3. Do some reek validations

    @mhenrixon
    mhenrixon committed Jun 20, 2018
    Configuration menu
    Copy the full SHA
    32e1e63 View commit details
    Browse the repository at this point in the history

  4. Use a separate module for connection

    @mhenrixon
    mhenrixon committed Jun 20, 2018
    Configuration menu
    Copy the full SHA
    60f8353 View commit details
    Browse the repository at this point in the history

  5. Turn off utility function for .|#redis

    @mhenrixon
    mhenrixon committed Jun 20, 2018
    Configuration menu
    Copy the full SHA
    aaa5090 View commit details
    Browse the repository at this point in the history

  6. Silence test output

    @mhenrixon
    mhenrixon committed Jun 20, 2018
    Configuration menu
    Copy the full SHA
    da9a0b5 View commit details
    Browse the repository at this point in the history

  7. Add integration specs for server

    @mhenrixon
    mhenrixon committed Jun 20, 2018
    Configuration menu
    Copy the full SHA
    447b771 View commit details
    Browse the repository at this point in the history

  8. Rename primadonna method

    @mhenrixon
    mhenrixon committed Jun 20, 2018
    Configuration menu
    Copy the full SHA
    574a834 View commit details
    Browse the repository at this point in the history

  9. Simplify Lock::UntilExecuted

    @mhenrixon
    mhenrixon committed Jun 20, 2018
    Configuration menu
    Copy the full SHA
    e80780a View commit details
    Browse the repository at this point in the history

  10. Make locksmith more readable

    @mhenrixon
    mhenrixon committed Jun 20, 2018
    Configuration menu
    Copy the full SHA
    087ff14 View commit details
    Browse the repository at this point in the history

  11. Styling, helper methods

    @mhenrixon
    mhenrixon committed Jun 20, 2018
    Configuration menu
    Copy the full SHA
    0b95a06 View commit details
    Browse the repository at this point in the history

  12. Styles

    @mhenrixon
    mhenrixon committed Jun 20, 2018
    Configuration menu
    Copy the full SHA
    3fb664d View commit details
    Browse the repository at this point in the history

  13. Make use of redis_pool

    @mhenrixon
    mhenrixon committed Jun 20, 2018
    Configuration menu
    Copy the full SHA
    5a0bf46 View commit details
    Browse the repository at this point in the history

  14. Don't silently hide errors

    @mhenrixon
    mhenrixon committed Jun 20, 2018
    Configuration menu
    Copy the full SHA
    298a9ae View commit details
    Browse the repository at this point in the history

  15. More cleanup

    @mhenrixon
    mhenrixon committed Jun 20, 2018
    Configuration menu
    Copy the full SHA
    0641e74 View commit details
    Browse the repository at this point in the history

Commits on Jun 21, 2018

  1. Cleanup implementation

    @mhenrixon
    mhenrixon committed Jun 21, 2018
    Configuration menu
    Copy the full SHA
    315016f View commit details
    Browse the repository at this point in the history

  2. Prevent digest from becoming nil

    @mhenrixon
    mhenrixon committed Jun 21, 2018
    Configuration menu
    Copy the full SHA
    0cc4ba5 View commit details
    Browse the repository at this point in the history

  3. This check is not needed

    @mhenrixon
    mhenrixon committed Jun 21, 2018
    Configuration menu
    Copy the full SHA
    8f1b367 View commit details
    Browse the repository at this point in the history