Skip to content

Commit

Permalink
Declare mock_redis as development dependency instead of runtime one
Browse files Browse the repository at this point in the history
  • Loading branch information
@phuongnd08
phuongnd08 committed Oct 19, 2014
1 parent 99b4db8 commit 9fdc855
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion sidekiq-unique-jobs.gemspec
View file
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ Gem::Specification.new do |gem|
gem.require_paths = ["lib"]
gem.version = SidekiqUniqueJobs::VERSION
gem.add_dependency 'sidekiq', '>= 2.6'
gem.add_dependency 'mock_redis'

This comment has been minimized.

Sign in to view

Copy link
@brand-it

brand-it Nov 13, 2014

By changing this it resulted in this file not working when required in rspec_helper.rb

LoadError:
       cannot load such file -- mock_redis

https://github.com/mhenrixon/sidekiq-unique-jobs/blob/master/lib/sidekiq_unique_jobs/testing.rb

I don't total know how this was to work but with out when ever you call perform_in it tries to require mock_redis. I have fixed this in my tests but it might be a issue for any one who updates to 3.0.9.

This comment has been minimized.

Sign in to view

Copy link
@mhenrixon

mhenrixon Nov 17, 2014

Owner

We require people to add it to their gemfile manually if they want to test in inline mode. It says so int the post install notes for the gem and in the readme and changelog. I'll make it more explicit in the readme and add some information about what goes wrong when we require mock_redis.

This comment has been minimized.

Sign in to view

Copy link
@brand-it

brand-it Nov 17, 2014

Got you thanks for the update.

This comment has been minimized.

Sign in to view

Copy link
@mhenrixon

mhenrixon Nov 17, 2014

Owner

I think outputting a warning and doing a fallback to work like it was before mock_redis rather than crashing the build/test would be sufficient.
gem.add_development_dependency 'mock_redis'
gem.add_development_dependency 'rspec', '~> 3.0.0.beta'
gem.add_development_dependency 'rake'
gem.add_development_dependency 'rspec-sidekiq'
Expand Down

0 comments on commit 9fdc855

Please sign in to comment.