Only apple sets data to 1 on write events...

mheily · Mar 19, 2024 · bac4a68 · bac4a68
1 parent b45e2af
commit bac4a68
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 4 deletions.
diff --git a/src/linux/write.c b/src/linux/write.c
@@ -41,10 +41,7 @@ evfilt_write_copyout(struct kevent *dst, UNUSED int nevents, struct filter *filt
     /*
      * Fast path for files...
      */
-    if (src->kn_flags & KNFL_FILE) {
-        dst->data = 1; /* To match macOS and FreeBSD */
-        goto done;
-    }
+    if (src->kn_flags & KNFL_FILE) goto done;
 
     if (ev->events & EPOLLHUP)
         dst->flags |= EV_EOF;

diff --git a/test/write.c b/test/write.c
@@ -36,8 +36,10 @@ test_kevent_write_regular_file(struct test_context *ctx)
     kevent_rv_cmp(0, kevent(ctx->kqfd, &kev, 1, NULL, 0, NULL));
     kevent_get(ret, NUM_ELEMENTS(ret), ctx->kqfd, 1);
 
+#ifdef __APPLE__
     /* macOS sets this high for some reason */
     kev.data = 1;
+#endif
 
     /* File should appear immediately writable */
     kevent_get(NULL, 0, ctx->kqfd, 1);