Update collection literals and comprehensions #2108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Avasam
force-pushed
the
Update-collections-literals-and-comprehensions
branch
from
2afab38 to
64a311e
Compare
mhammond
approved these changes
Sep 21, 2023
This was referenced Mar 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extracted from, and improved over #2100
These were found by running
ruff . --select=C4 --exclude=build --exclude=Pythonwin/Scintilla --exclude=adodbapiDocumentation: https://beta.ruff.rs/docs/rules/#flake8-comprehensions-c4
This PR uses more modern collection literals and comprehensions where applicable. There's some expected performance gains here from the use of comprehensions and less function call overhead. On top of often more concise syntax