Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace imp module with importlib #1256 #1537

Merged
merged 1 commit into from
Jun 22, 2020
Merged

Replace imp module with importlib #1256 #1537

merged 1 commit into from
Jun 22, 2020

Conversation

efahl
Copy link
Contributor

@efahl efahl commented Jun 17, 2020

No description provided.

@efahl efahl changed the title Replace imp module with import lib (issue 1256). Replace imp module with importlib #1256 Jun 18, 2020
@mhammond
Copy link
Owner

Thanks!

@mhammond mhammond merged commit 5c39439 into mhammond:master Jun 22, 2020
mhammond added a commit that referenced this pull request Jun 22, 2020
@mhammond
Revert "Replace imp module with import lib (issue 1256). (#1537)" for…
c325739 
… python2 breakage.

I'll reapply it after killing python 2.

This reverts commit 5c39439.
@efahl efahl deleted the HEAD branch June 22, 2020 17:36
@efahl
Copy link
Contributor Author

efahl commented Jun 22, 2020

Mark, thanks to you for pywin32, been using it for many years.

I have been waiting for Python 2 support to be dropped before submitting this. I think it covers both #1256 and #1503, so you should be able to close those.

@brgirgis
Copy link

When is this change scheduled to be released?

@henrycjc
Copy link

henrycjc commented Mar 23, 2021 •
edited
Loading

Hello @mhammond - could you please create a new release of pywin32 to include the changes in this PR? Per #1256

Edit: apologies. I was not on the latest version where this issue has been resolved.

@Avasam Avasam mentioned this pull request Aug 23, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@efahl @mhammond @brgirgis @henrycjc