feat: implement Clone for TranslationOptions
#4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since the struct does not implement the trait, it's difficult to reuse the same options across multiple requests. The another way might include to provided a custom `copy` or a `new` method that takes a reference to the original struct, and creates a new with the same data. But since the struct (1) does not contain any reference, (2) does not contain fields which is hard or impossible to clone such as I/O resources, and (3) is a fairly small so that the cost of clone is negligible.
clap-rs/clap#4602 changed the start of the error messages to lower case. Since the change is trivial, I included this into the same PR. Ref.: clap-rs/clap#4602
|
🙏 Released as v0.4.1. |
|
Thank you for the prompt action! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First of all, thanks for making the crate open!
Since the struct does not implement the trait, it's difficult to reuse the same options across multiple requests.
The another way might include to provided a custom
copyor anewmethod that takes a reference to the original struct, and creates a new with the same data. But since the struct (1) does not contain any reference, (2) does not contain fields which is hard or impossible to clone such as I/O resources, and (3) is a fairly small so that the cost of clone is negligible.Please let me know your thoughts. Thanks!