Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix HSL and HSLA Colors with double converters #55

Merged
merged 4 commits into from
Jan 7, 2020

Conversation

bbenetskyy
Copy link
Collaborator

Fixed Bug #40 - HSL(a) with double value throw Over Flow Exception

Solution - Update to Xamarin.Forms v4.4 where that bug is fixed.

API changes - N/A

@bbenetskyy bbenetskyy added the 🍄 bug Something isn't working label Jan 4, 2020
@bbenetskyy bbenetskyy added this to the v1.0.1 milestone Jan 4, 2020
@bbenetskyy bbenetskyy force-pushed the bugfix/hsl-overflow-exceptions branch from 715b86a to 39636dc Compare January 4, 2020 10:16
@bbenetskyy
Copy link
Collaborator Author

image

<Description>Draw breathtaking backgrounds in your Xamarin.Forms application. It's a kind of magic. Powered by SkiaSharp.

===================
* Fixed bug with converting double values for HSL and HSLA Colors</Description>
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we could move this to release notes wiki page?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Moved to Wiki🙂

@bbenetskyy bbenetskyy merged commit 04f6e57 into master Jan 7, 2020
@bbenetskyy bbenetskyy deleted the bugfix/hsl-overflow-exceptions branch January 7, 2020 08:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🍄 bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants