Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare release 1.3 #167

Merged
merged 6 commits into from
Apr 26, 2021
Merged

Prepare release 1.3 #167

merged 6 commits into from
Apr 26, 2021

Conversation

mgierlasinski
Copy link
Owner

No description provided.

@mgierlasinski mgierlasinski added the 🛠️ enhancement New feature or request label Apr 25, 2021
@mgierlasinski mgierlasinski added this to the v1.3.0 milestone Apr 25, 2021
Copy link
Collaborator

@bbenetskyy bbenetskyy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All is ok, just one question about Init method 👌👍

Comment on lines +5 to +8
public static void Init()
{

}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we still need that at Toolkit?

According to just merged PR - #164 (comment)

We don't need that, is that was added by mistake, or something has been changed since that time?

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was added before that PR and is preventing compilation error in playground so I left it. For toolkit it doesn't matter so much, it's just an experiment.

@mgierlasinski mgierlasinski merged commit 39efb6c into master Apr 26, 2021
@mgierlasinski mgierlasinski deleted the prepare-release-1.3 branch April 26, 2021 04:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🛠️ enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants