Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README badges #97

Merged
merged 1 commit into from
Feb 11, 2021
Merged

Update README badges #97

merged 1 commit into from
Feb 11, 2021

Conversation

mgeisler
Copy link
Owner

No description provided.

@mgeisler mgeisler enabled auto-merge February 11, 2021 22:28
@mgeisler mgeisler merged commit 826bbd4 into master Feb 11, 2021
@mgeisler mgeisler deleted the update-readme-badges branch February 11, 2021 22:28
@lopopolo
Copy link
Contributor

Sorry for lurking on your PRs @mgeisler, but I think these two badges in Cargo.toml are obsolete now:

version-sync/Cargo.toml

Lines 18 to 19 in e8a995c

travis-ci = { repository = "mgeisler/version-sync" }
appveyor = { repository = "mgeisler/version-sync" }

@github-actions github-actions bot mentioned this pull request Feb 13, 2021
mgeisler added a commit that referenced this pull request Feb 14, 2021
The badges are no longer shown on crates.io and I don’t think they
were ever shown on lib.rs. According to the documentation we should
instead rely on the badges in the README.

  https://doc.rust-lang.org/cargo/reference/manifest.html#the-badges-section

Thanks @lopopolo for noticing this on #97.
@mgeisler
Copy link
Owner Author

Thanks for double-checking this, @lopopolo, much appreciated! I can certainly need an extra pair of eyes to catch errors :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants