Check version numbers in =1.2.3 and >1.2.3, and >=1.2.3
#115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before, a dependency specified as ```toml [dependencies] foo = ">= 1.2.3, < 2.0" ``` was ignored since it was deemed too complicated to check versions requirements with multiple comparators. We now handle such cases by checking every comparator individually. Comparators which form a lower-bound for the version is checked. This means that version requirements of the form * `1.2` and `^1.2` * `~1.2` * `=1.2` * `>1.2` * `>=1.2` * `1.2.*` are all checked for compatibility with the actual crate version. If the crate version is higher than the version requirement, an error is returned. Upper-build version requirements such as `<2.0` are ignored like before.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before, a dependency specified as
was ignored since it was deemed too complicated to check versions
requirements with multiple comparators.
We now handle such cases by checking every comparator individually.
Comparators which form a lower-bound for the version is checked. This
means that version requirements of the form
1.2and^1.2~1.2=1.2>1.2>=1.21.2.*are all checked for compatibility with the actual crate version. If
the crate version is higher than the version requirement, an error is
returned.
Upper-build version requirements such as
<2.0are ignored likebefore.