-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow to check non-markdown sources #17
Comments
Maybe another note how I think this should work (just my 2ct): I guess the best idea would be to check the file for the version pattern (as in |
Hi Matthias, thanks for the feedback! I would definitely like to support this! I've been thinking about adding a more free form check. Perhaps it could be something where you specify a regular expression with a placeholder? The API might be as simple as a path and a regexp that selects the line you're interested in: assert_version_updated!("my-pandoc-header.md", "version: $VERSION"); where |
Well, you wouldn't even need to add the version in the string. Because you can aggregate that inside the macro, as you already do with the existing ones. Only a pattern would suffice I guess. |
The new assert_contains_regex macro makes it easy to check that the current version number is mentioned in a given file. Fixes #17.
The new assert_contains_regex macro makes it easy to check that the current version number is mentioned in a given file. Fixes #17.
The new assert_contains_regex macro makes it easy to check that the current version number is mentioned in a given file. Fixes #17.
The new assert_contains_regex macro makes it easy to check that the current version number is mentioned in a given file. Fixes #17.
The new assert_contains_regex macro makes it easy to check that the current version number is mentioned in a given file. Fixes #17.
Hi,
just found your crate from your post and I love it!
This is a feature request: In my project, I have some files which are not markdown, but contain version numbers. Mainly the pandoc documentation header file. Therefor it would be awesome if there would be a possibility to also check plain text files.
I know, for most uses this is not what one wants, but for this specific use case it is of great importance... and I'd bet it is easy to implement!
The text was updated successfully, but these errors were encountered: