Add lipsum_from_seed and tweak capitalization.
#73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi Martin, Your PR looks great, thanks! I agree completely that we shouldn't have stray punctuation in the sentences :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey,
thanks for the nice library!
I'm considering using this in one of my projects to allow users to create blind text of arbitrary length. I'd prefer everyone to have the same output for a given length while preserving the iconic start "Lorem ipsum dolor sit amet". Hence, I needed a function combining the properties of
lipsumandlipsum_words_from_seed. I addedlipsum_from_seed(very easy thanks to great design!) for this purpose and rearranged both its andlipsum_words_from_seeddoc string a bit as to not make the function overview to wordy.While implementing the new function, I realized that
lipsumwill sometimes yield strings like"Nullam habuit. voluptatem cum summum."containing punctuation followed by non-capitalized words. This did not look very nice to me, so I adjustedjoin_wordsto always capitalize after a.,?, or!.I hope these changes align with your plan for the library and match the style used so far. I'm happy to make stylistic changes to the PR!