Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add --no-build-isolation so check-manifest can succeed without an internet connection #128

Merged
merged 1 commit into from
Oct 30, 2020
Merged

Add --no-build-isolation so check-manifest can succeed without an internet connection #128

merged 1 commit into from
Oct 30, 2020

Conversation

asottile
Copy link
Contributor

this is a bit of a proof-of-concept I wanted to float before committing more to this

the reason I wanted to try and tackle this is @graingert wanted to use check-manifest in https://pre-commit.ci (which forbids network at runtime for free tier because I'd rather not deal with abuse for free 😄)

with this dockerfile:

FROM ubuntu:focal
RUN : \
    && apt-get update \
    && DEBIAN_FRONTEND=noninteractive apt-get install -y --no-install-recommends \
        git \
        ca-certificates \
        python3-venv \
    && apt-get clean \
    && rm -rf /var/lib/apt/lists/*
RUN git clone https://github.com/twisted/ldaptor
COPY . /code
RUN python3 -m venv /venv && /venv/bin/pip install /code wheel

I'm able to get ldaptor passing:

$ docker run --rm -ti --net=none --workdir /ldaptor foo /venv/bin/check-manifest --no-build-isolation
lists of files in version control and sdist match

Copy link

@gaborbernat gaborbernat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Owner

@mgedmin mgedmin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Would you like to add a changelog note for this change? I think it's also worth mentioning (separately from the new command-line argument) about the switch from the deprecated pep517.build to python-build (I hope I got the project name right; I know the package is just build on pypi but it's very generic and ungooglable).

check_manifest.py Outdated Show resolved Hide resolved
@asottile
Copy link
Contributor Author

cool! I also added a little blurb / example as well to the pre-commit documentation

@mgedmin mgedmin merged commit b5fbe18 into mgedmin:master Oct 30, 2020
@mgedmin
Copy link
Owner

mgedmin commented Oct 30, 2020

Thank you! check-manifest 0.45 is released now.

@asottile asottile deleted the no_build_isolation branch October 30, 2020 23:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants