Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Doesn't work with Python 2.6 #22

Closed
rassie opened this issue Jan 17, 2014 · 3 comments
Closed

Doesn't work with Python 2.6 #22

rassie opened this issue Jan 17, 2014 · 3 comments

Comments

@rassie
Copy link

rassie commented Jan 17, 2014

According to docs, TarFile only supports context manager protocol since 2.7, so that on 2.6 check-manifest crashes with AttributeError: 'TarFile' object has no attribute '__exit__'
@mgedmin
Copy link
Owner

mgedmin commented Jan 20, 2014

Yes, check-manifest currently does not support Python 2.6. The Python version classifiers in setup.py should make that clear.

I'm not opposed to adding Python 2.6 support. Would you like to submit a pull request? The tarfile error can be worked around by using with closing(tarfile.open(...)) as tf:.

@mgedmin
Copy link
Owner

mgedmin commented Jan 30, 2014

Okay, I just added Python 2.6 support without fixing the tarfile issue. My tests are incomplete :/

@mgedmin mgedmin reopened this Jan 30, 2014
mgedmin added a commit that referenced this issue Jan 30, 2014
@mgedmin
Fix another AttributeError: __exit__ on Python 2.6
b8cc282 
This time while we're dealing with zip archives.

Fixes #22 harder.

I wonder how many other latent bugs are still lurking, thanks to the
less-than-stellar test coverage?
@mgedmin
Copy link
Owner

mgedmin commented Jan 30, 2014

check-manifest 0.18 is out with this fix.

@mgedmin mgedmin mentioned this issue Jan 30, 2014
Closed
@prateek prateek mentioned this issue Oct 17, 2015
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rassie @mgedmin