Submodule and sub-directory project is broken

[bersace]

Hi,

Say you have a repository with a Python project in a subdirectory and a submodule :

top_srcdir/
                /.gitmodules
                /project/
                            /setup.py
                            /MANIFEST.in
                            /submodule

check-manifest 0.47 project/ fails to determine the presence of a submodule becase _has_submodules checks for project/.gitmodules instead of top level .gitmodules.

A workaround is to put an empty project/.gitmodules file.

May I suggest to always call ls-files with --recurse-submodules ?

Thanks for check-manifest.

[mgedmin]

The only reason I'm not always passing --recurse-submodules to git ls-files is that it used to be horrendously slow on Windows back when I maintained my own Jenkins builds on a Windows VM. Builds literally took hours.

I no longer maintain a Jenkins, and I believe newer Git versions have rewritten the submodule recursion code in C rather than the shell script that it used before, so it should be fine to remove that workaround.

(Also, I hadn't realized that .gitmodules could exist in any subdirectory, not just at the top level.)

EDIT: I completely forgot that there was a second reason not to pass --recurse-submodules: older Git versions didn't support it (see #124). Oh well, who says I have to support 6-year old Git versions?

[mgedmin]

Released check-manifest 0.48 with a fix for this.

[bersace]

You're awesome. I had hard time too maintaining Jenkins CI. Kudo !