Check function literals in unused-param
#966
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
denisvmedia
reviewed
Jan 22, 2024
|
Hi @StephenButtolph, thanks for the PR and the proposal for improving the rule. I'll try to review the PR in the coming days. |
Co-authored-by: Stephen Buttolph <stephen@avalabs.org>
|
merged, thanks @StephenButtolph |
eikemeier
added a commit
to fillmore-labs/async-exp
that referenced
this pull request
Feb 9, 2024
eikemeier
added a commit
to fillmore-labs/async-exp
that referenced
this pull request
Feb 9, 2024
manishym
added a commit
to manishym/go-ceph
that referenced
this pull request
Feb 13, 2024
revive v1.3.7 added mgechev/revive#966 which checks for unused parameters in function literals. This caused several lint errors in go-ceph code. Signed-off-by: Manish <myathnal@redhat.com>
5 tasks
mergify bot
pushed a commit
to ceph/go-ceph
that referenced
this pull request
Feb 13, 2024
revive v1.3.7 added mgechev/revive#966 which checks for unused parameters in function literals. This caused several lint errors in go-ceph code. Signed-off-by: Manish <myathnal@redhat.com>
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #965
See #965 for the motivation behind this PR.
This does potentially significantly change the performance of this rule because we will now walk into the function bodies. If we are concerned about a performance regression here I think an alternative could be to either add a new rule or add a configuration to the rule to gate checking anonymous functions.