Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix trailing whitespaces #917

Merged
merged 1 commit into from
Oct 27, 2023
Merged

Conversation

mfederowicz
Copy link
Contributor

cleanup in few files containing trailing whitespace and incorrect end line

no tests needed

Makefile Outdated
@@ -16,4 +16,3 @@ build:

test:
@go test -v -race ./...

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmm interesting because it is result of end-of-file-fixer hook from https://github.com/pre-commit/pre-commit-hooks :)

this hook have description:

id: end-of-file-fixer
    name: fix end of files
    description: ensures that a file is either empty, or ends with one newline.

other files *.go in commits have removed last line, so we have a proof that hook not works well :(

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok @chavacava i removed commit related to end of files, and leave related with trailing white spaces :)

@mfederowicz mfederowicz changed the title Fix end of files and trailing whitespaces Fix trailing whitespaces Oct 26, 2023
@chavacava chavacava merged commit bcae8c7 into mgechev:master Oct 27, 2023
@mfederowicz mfederowicz deleted the fix-end-of-files branch October 2, 2024 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants