Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: simplify tests #1089

Merged
merged 1 commit into from
Nov 4, 2024
Merged

refactor: simplify tests #1089

merged 1 commit into from
Nov 4, 2024

Conversation

alexandear
Copy link
Contributor

This PR simplifies test code.

Explanation:

  • len(revive.lintingRules) is 0 if revive.lintingRules is nil.
  • The lambda func(file string) ([]byte, error) { return os.ReadFile(file) } can be simply os.ReadFile.
  • Every case has an implicit break statement, which is familiar to every Go developer.

@chavacava chavacava merged commit 6228ba5 into mgechev:master Nov 4, 2024
4 checks passed
@alexandear alexandear deleted the refactor/simplify-tests branch November 4, 2024 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ccoVeille ccoVeille ccoVeille approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alexandear @ccoVeille @chavacava