Skip to content

Commit

Permalink
chore: remove unused #region comments (#1181)
Browse files Browse the repository at this point in the history
  • Loading branch information
alexandear authored Dec 9, 2024
1 parent f94c9d7 commit 10d9697
Showing 1 changed file with 0 additions and 20 deletions.
20 changes: 0 additions & 20 deletions rule/string_format.go
Original file line number Diff line number Diff line change
Expand Up @@ -11,8 +11,6 @@ import (
"github.com/mgechev/revive/lint"
)

// #region Revive API

// StringFormatRule lints strings and/or comments according to a set of regular expressions given as Arguments
type StringFormatRule struct{}

Expand Down Expand Up @@ -56,10 +54,6 @@ func (StringFormatRule) ParseArgumentsTest(arguments lint.Arguments) *string {
return nil
}

// #endregion

// #region Internal structure

type lintStringFormatRule struct {
onFailure func(lint.Failure)
rules []stringFormatSubrule
Expand Down Expand Up @@ -87,10 +81,6 @@ const identRegex = "[_A-Za-z][_A-Za-z0-9]*"
var parseStringFormatScope = regexp.MustCompile(
fmt.Sprintf("^(%s(?:\\.%s)?)(?:\\[([0-9]+)\\](?:\\.(%s))?)?$", identRegex, identRegex, identRegex))

// #endregion

// #region Argument parsing

func (w *lintStringFormatRule) parseArguments(arguments lint.Arguments) {
for i, argument := range arguments {
scopes, regex, negated, errorMessage := w.parseArgument(argument, i)
Expand Down Expand Up @@ -196,10 +186,6 @@ func (lintStringFormatRule) parseScopeError(msg string, ruleNum, option, scopeNu
panic(fmt.Sprintf("failed to parse configuration for string-format: %s [argument %d, option %d, scope index %d]", msg, ruleNum, option, scopeNum))
}

// #endregion

// #region Node traversal

func (w lintStringFormatRule) Visit(node ast.Node) ast.Visitor {
// First, check if node is a call expression
call, ok := node.(*ast.CallExpr)
Expand Down Expand Up @@ -247,10 +233,6 @@ func (lintStringFormatRule) getCallName(call *ast.CallExpr) (callName string, ok
return "", false
}

// #endregion

// #region Linting logic

// apply a single format rule to a call expression (should be done after verifying the that the call expression matches the rule's scope)
func (r *stringFormatSubrule) apply(call *ast.CallExpr, scope *stringFormatSubruleScope) {
if len(call.Args) <= scope.argument {
Expand Down Expand Up @@ -324,5 +306,3 @@ func (r *stringFormatSubrule) generateFailure(node ast.Node) {
Node: node,
})
}

// #endregion

0 comments on commit 10d9697

Please sign in to comment.