Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: changes to access screen #603

Merged
merged 2 commits into from
Sep 19, 2024
Merged

chore: changes to access screen #603

merged 2 commits into from
Sep 19, 2024

Conversation

mfts
Copy link
Owner

@mfts mfts commented Sep 19, 2024

No description provided.

Copy link

vercel bot commented Sep 19, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
papermark ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 19, 2024 8:09am

Copy link

what-the-diff bot commented Sep 19, 2024

PR Summary

  • Introduction of Custom Access
    A new property, useCustomAccessForm, has been added across multiple components. This allows increased flexibility and customization across various sections including agreements, emails, views, and forms.

  • Display Adjustments in Agreement Section
    The rendering of the "Privacy Policy" within the Agreement Section now is conditional and will display if the useCustomAccessForm property is set to be true.

  • Update in Email Text
    The shared data message in the Email Section has been tweaked to reflect the status of the useCustomAccessForm property.

  • Changes in Access Form
    The rendering in the Access Form has been adjusted. This excludes the Papermark branding message if the useCustomAccessForm property is true which gives a more personalized approach.

  • Enhancements in Prop Functions
    The getStaticProps functions in several pages have been improved. They can now evaluate useCustomAccessForm based on a given teamId which provides more precise data.

  • Update in ViewPage Logic
    The isProtected logic in ViewPage now considers enableAgreement alongside existing checks, providing a more comprehensive protected view control.

  • Code Simplification
    The code in ViewPage for rendering protected views has been simplified by eliminating outdated or commented-out elements. It makes the code cleaner and easier to manage.

@mfts mfts merged commit 7f8bb05 into main Sep 19, 2024
2 checks passed
@mfts mfts deleted the chore/access-screen branch October 27, 2024 11:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant