Fix bug with overriding #setup/#teardown on Minitest::Spec #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If any of other test helping library calls ::MiniTest::Spec.before or ::MiniTest::Spec.after, the last one called wins. That should not be the case. It makes for really had to track down bugs Fixes mfpiccolo#24
This gem is tested on 2.1 and lower so upgrading not needed.
|
@mfpiccolo - Your CI I believe has been broken for 1.9.3. It has nothing to do with my changes. Can you merge this in? |
|
Hey everyone -- I just got burned by this bug not being fixed on master. @Aryk 's awesome fix got me working again but would be awesome to merge this so other people don't suffer the same fate. Anything I can do to help get this rolling? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #24.
Now other gems can extend the setup and teardown methods with their own modules.