Use CMAKE_INSTALL_LIBDIR in CONF_CMAKE_INSTALL_DIR #472
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On some platforms (like RedHat ones), CMAKE_INSTALL_LIBDIR is set to `lib64` instead of `lib`. The CMake files should also be installed to `lib64`, but because CONF_CMAKE_INSTALL_DIR is set unconditionally to use `lib`, the proper path can't be configured. This change makes CONF_CMAKE_INSTALL_DIR use the configured CMAKE_INSTALL_LIBDIR value, which defaults to `lib`.
|
Thanks @cottsay! |
laudrup
pushed a commit
to laudrup/libtins
that referenced
this pull request
Nov 23, 2022
On some platforms (like RedHat ones), CMAKE_INSTALL_LIBDIR is set to `lib64` instead of `lib`. The CMake files should also be installed to `lib64`, but because CONF_CMAKE_INSTALL_DIR is set unconditionally to use `lib`, the proper path can't be configured. This change makes CONF_CMAKE_INSTALL_DIR use the configured CMAKE_INSTALL_LIBDIR value, which defaults to `lib`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On some platforms (like RedHat ones), CMAKE_INSTALL_LIBDIR is set to
lib64instead oflib. The CMake files should also be installed tolib64, but because CONF_CMAKE_INSTALL_DIR is set unconditionally to uselib, the proper path can't be configured.This change makes CONF_CMAKE_INSTALL_DIR use the configured CMAKE_INSTALL_LIBDIR value, which defaults to
lib.An alternative to this change would be to allow CONF_CMAKE_INSTALL_DIR to be specified manually rather than unconditionally setting it.