Skip to content

Commit

Permalink
Reformatting
Browse files Browse the repository at this point in the history
  • Loading branch information
mfherbst committed Nov 2, 2022
1 parent e1baa2d commit 61f6886
Show file tree
Hide file tree
Showing 2 changed files with 9 additions and 7 deletions.
2 changes: 1 addition & 1 deletion src/ASEconvert.jl
Original file line number Diff line number Diff line change
Expand Up @@ -97,7 +97,7 @@ function convert_ase(system::AbstractSystem{D}) where {D}
# TODO Implement and make use of a property interface on the system level
info = Dict(string(k) => v for (k, v) in system.data)
else
info = Dict{String,Any}()
info = Dict{String, Any}()
end

ase.Atoms(; symbols, positions, cell, pbc, velocities, info, extra...)
Expand Down
14 changes: 8 additions & 6 deletions test/runtests.jl
Original file line number Diff line number Diff line change
Expand Up @@ -112,11 +112,13 @@ end
@test velocity(bulk_Fe) == [[0.0, 0.0, 0.0], [0.0, 0.0, 0.0]]u"Å/s"
end

@testset "Writing files using ASE" begin mktempdir() do d
file = joinpath(d, "output.xyz")
ase.io.write(file, convert_ase(system))
@testset "Writing files using ASE" begin
mktempdir() do d
file = joinpath(d, "output.xyz")
ase.io.write(file, convert_ase(system))

newsystem = ExtXYZ.Atoms(ExtXYZ.read_frame(file))
test_approx_eq(system, newsystem; atol=1e-7, ignore_missing=true)
end end
newsystem = ExtXYZ.Atoms(ExtXYZ.read_frame(file))
test_approx_eq(system, newsystem; atol=1e-7, ignore_missing=true)
end
end
end

3 comments on commit 61f6886

@mfherbst
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mfherbst
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JuliaRegistrator
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Registration pull request created: JuliaRegistries/General/71525

After the above pull request is merged, it is recommended that a tag is created on this repository for the registered package version.

This will be done automatically if the Julia TagBot GitHub Action is installed, or can be done manually through the github interface, or via:

git tag -a v0.1.0 -m "<description of version>" 61f6886e37c2b995e620caee2004f29ed7426ea9
git push origin v0.1.0

Please sign in to comment.