Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please add support for real-time push #190

Closed
robzhu opened this issue Feb 1, 2015 · 3 comments
Closed

Please add support for real-time push #190

robzhu opened this issue Feb 1, 2015 · 3 comments

Comments

@robzhu
Copy link

robzhu commented Feb 1, 2015

RethinkDB 1.16 adds real-time features, as described here: http://rethinkdb.com/blog/1.16-release/

Specifically, appending .changes() to a query will cause updates to be pushed whenever that query's result would change. Any chance this functionality can be added to the driver?

@mfenniak
Copy link
Owner

mfenniak commented Feb 1, 2015

The current unreleased version of the driver (in GitHub) does support the Changes command on a single target table. The current support was added in the commit 74331f3, where you can see it being used in a test program.

RethinkDB 1.16 looks like it adds support for a bunch of filter-based change monitoring, which sounds cool. It probably wouldn't be hard to update the support in rethinkdb-net by changing RethinkDb.QueryTerm to operate on an ISequenceQuery rather than an ITableQuery, updating the Query factory constructor, and then writing some updated tests. I won't be able to jump on this immediately, but, I'd happily review a pull request! :-)

@robzhu
Copy link
Author

robzhu commented Feb 3, 2015

Thanks Mathieu, I'm not familiar enough with the code-base yet to make such a change, but I'll start looking into it.

mfenniak added a commit that referenced this issue Mar 27, 2015
Partial implementations of #190 and #193; missing unit tests currently.
mfenniak added a commit that referenced this issue Apr 13, 2015
Partial implementations of #190 and #193; missing unit tests currently.
mfenniak added a commit that referenced this issue Apr 14, 2015
Partial implementations of #190 and #193; missing unit tests currently.
mfenniak added a commit that referenced this issue Apr 14, 2015
Partial implementations of #190 and #193; missing unit tests currently.
@mfenniak
Copy link
Owner

PR #199 added support for real-time push for most of the filters and operations supported by RethinkDB 1.16. There are a couple of filter cases that weren't added, that I've created individual issues for: #197, #198.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants