Rethink 1.10 - Multi-Index Support

[bchavez]

If I'm not mistaken, currently, there's no support for the "multi-index" parameter when creating indexes ...

http://rethinkdb.com/blog/1.10-release/

{
  ...,
  "tags": ["feature", "ReQL", "secondary_indexes"],
  ...
}

r.table('github_issues').index_create('tags', multi=true).run(conn)
r.table('github_issess').get_all('feature', index='tags')

And the official documentation for multi-index support: http://www.rethinkdb.com/api/javascript/index_create/

So, looking at the C# driver code, I stumbled upon: CreateIndexQuery.cs. It appears, that all we need to do to support the multi index parameter is attach a "multi" datum to "indexCreate.optargs"?

Something like this:

indexCreate.optargs.Add( new Term.AssocPair
                {
                    key = "multi",
                    val = new Term
                        {
                            type = Term.TermType.DATUM,
                            datum = new Datum
                                {
                                    type = Datum.DatumType.R_BOOL,
                                    r_bool = true | false ???
                                }
                        }
                } );

I'm not really sure about the structures of Term specs. So, it's only a guess. If it's this easy, perhaps I could write it. Please advise. thx.

[mfenniak]

Looks like you've nailed what would be needed here. The addition of the optarg as you've described, plus:

• A new field in CreateIndexQuery (readonly, set by constructor)
• An optional parameter to Query.IndexCreate to pass into the CreateIndexQuery constructor; default false
• A unit test

[dragan]

Just a small note, the CI mono agent was already running 1.10.0, but I just finished updating to 1.10.1 so we're all set on the CI side for this feature.