Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update dependency elie29/zend-phpdi-config to accept v9 #83

Merged
merged 2 commits into from
Oct 17, 2022
Merged

Update dependency elie29/zend-phpdi-config to accept v9 #83

merged 2 commits into from
Oct 17, 2022

Conversation

elie29
Copy link
Contributor

@elie29 elie29 commented Sep 25, 2022 •
edited
Loading

Q A
Documentation no
Bugfix yes
BC Break no
New Feature yes
RFC yes
QA no

Description

Update elie29/zend-phpdi-config to accept v9.0 in order to be compatible with php 8.1

@renovate
Update dependency elie29/zend-phpdi-config to v9
181aa7a 
| datasource | package                  | from  | to    |
| ---------- | ------------------------ | ----- | ----- |
| packagist  | elie29/zend-phpdi-config | 6.0.0 | 9.0.0 |


Signed-off-by: Renovate Bot <bot@renovateapp.com>
@elie29 elie29 changed the title update dependency elie29/zend-phpdi-config to accept v9 #82 Update dependency elie29/zend-phpdi-config to accept v9 #71 Sep 25, 2022
@elie29 elie29 changed the title Update dependency elie29/zend-phpdi-config to accept v9 #71 Update dependency elie29/zend-phpdi-config to accept v9 Sep 25, 2022
@elie29 elie29 mentioned this pull request Sep 25, 2022
Merged
1 task
Ocramius
Ocramius requested changes Sep 25, 2022
View reviewed changes
Copy link
Member

@Ocramius Ocramius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This patch is alright, but I suggest doing it with composer update nothing to force just the content-hash to update.

That should keep the lock file compatible with the current setup, whilst allowing installation on newer versions too.

@Ocramius Ocramius added Enhancement New feature or request dependencies Pull requests that update a dependency file labels Sep 25, 2022
@Ocramius
Copy link
Member

Actually, your patch is good, just unsure about these reported issues:

 Error: src/MezzioInstaller/OptionalPackages.php:245:13: MixedAssignment: Unable to determine the type that $answer is being assigned to (see https://psalm.dev/032)
Error: src/MezzioInstaller/OptionalPackages.php:621:13: MixedAssignment: Unable to determine the type that $answer is being assigned to (see https://psalm.dev/032)
Error: src/MezzioInstaller/OptionalPackages.php:634:89: MixedArgument: Argument 2 of preg_match cannot be mixed, expecting string (see https://psalm.dev/030)

I wonder if we should just baseline those: they are only related to the console abstractions.

@elie29 elie29 mentioned this pull request Sep 26, 2022
Closed
@elie29
Update dependency elie29/zend-phpdi-config to accept v9 #71
d5f7241 
Signed-off-by: Elie NEHME <elie29@gmail.com>
@Ocramius Ocramius changed the base branch from renovate/elie29-zend-phpdi-config-9.x to 3.12.x October 17, 2022 07:32
@Ocramius Ocramius self-assigned this Oct 17, 2022
@Ocramius Ocramius added this to the 3.12.0 milestone Oct 17, 2022
Ocramius
Ocramius approved these changes Oct 17, 2022
View reviewed changes
Copy link
Member

@Ocramius Ocramius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @elie29!

@Ocramius Ocramius merged commit 43f4999 into mezzio:3.12.x Oct 17, 2022
@elie29 elie29 deleted the renovate/elie29-zend-phpdi-config-9.x branch October 17, 2022 08:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ocramius Ocramius Ocramius approved these changes

Assignees

@Ocramius Ocramius

Labels
dependencies Pull requests that update a dependency file Enhancement New feature or request
Projects
None yet
Milestone
3.12.0
Development

Successfully merging this pull request may close these issues.
2 participants
@elie29 @Ocramius