Test on PHP 8 and adapt resource handling #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meyfa
added
enhancement
meyfa
added a commit
that referenced
this pull request
Feb 18, 2022
PHP 8 uses an image class instead of resources for GD images. See #3. We can simply adapt the behavior to be conditional, to hopefully gain support for all PHP versions from 5.3.3 to 8.
meyfa
added a commit
that referenced
this pull request
Feb 18, 2022
* v1.x: chore(ci): Use GitHub Actions instead of Travis * v1.x: fix(ci): Remove leading dot for phpunit XML files This will make it possible for PHPUnit to autodiscover those files and mirrors the repo state on the main branch. * v1.x: fix(ci): Reference matrix.php-versions correctly * v1.x: fix(ci): Add test bootstrap for PHPUnit 4.8 on PHP 8 support * v1.x: fix: Add missing PHP 8 support PHP 8 uses an image class instead of resources for GD images. See #3. We can simply adapt the behavior to be conditional, to hopefully gain support for all PHP versions from 5.3.3 to 8. * v1.x: fix(tests): Skip resource freeing test on PHP 8
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PHP 8 uses an opaque
\GdImageclass instead of resources for images.This results in failures with code using
is_resource(), as well as test case failures forimagedestroy()because PHP 8 only destroys images during garbage collection.This PR addresses both of these problems.