feat: Add ability to define pixel difference calculators #17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add default calculation method and scaled alpha calculation method.
meyfa
changed the title
|
Thanks so much, this looks good to me! Nicely done. I think this needs some documentation though, would you like to add that to the README? |
|
Of course, I'll try and sort that out in the next day or two. |
|
Sorry for the delay @meyfa - documentation has now been added to the README. |
meyfa
reviewed
Apr 16, 2024
|
@bennothommo No worries! This is really awesome, thank you so much for this great PR! |
meyfa
added a commit
that referenced
this pull request
Apr 16, 2024
This is a backport of PR #17 to the v1.x release branch. Co-Authored-By: Ben Thomson <15900351+bennothommo@users.noreply.github.com>
meyfa
added a commit
that referenced
this pull request
Apr 16, 2024
This is a backport of PR #17 to the v1.x release branch. Co-Authored-By: Ben Thomson <15900351+bennothommo@users.noreply.github.com>
meyfa
added a commit
that referenced
this pull request
Apr 16, 2024
This is a backport of PR #17 to the v1.x release branch. Co-Authored-By: Ben Thomson <15900351+bennothommo@users.noreply.github.com>
meyfa
added a commit
that referenced
this pull request
Apr 16, 2024
This is a backport of PR #17 to the v1.x release branch. Co-Authored-By: Ben Thomson <15900351+bennothommo@users.noreply.github.com>
meyfa
pushed a commit
that referenced
this pull request
Apr 16, 2024
This is a backport of PR #17 to the v2.x release branch. Co-Authored-By: Ben Thomson <15900351+bennothommo@users.noreply.github.com>
meyfa
pushed a commit
that referenced
this pull request
Apr 16, 2024
This is a backport of PR #17 to the v2.x release branch. Co-Authored-By: Ben Thomson <15900351+bennothommo@users.noreply.github.com>
meyfa
pushed a commit
that referenced
this pull request
Apr 16, 2024
This is a backport of PR #17 to the v3.x release branch. Co-Authored-By: Ben Thomson <15900351+bennothommo@users.noreply.github.com>
meyfa
added a commit
that referenced
this pull request
Apr 16, 2024
This is a backport of PR #17 to the v1.x release branch. Co-authored-by: Ben Thomson <15900351+bennothommo@users.noreply.github.com>
meyfa
pushed a commit
that referenced
this pull request
Apr 16, 2024
This is a backport of PR #17 to the v2.x release branch. Co-authored-by: Ben Thomson <15900351+bennothommo@users.noreply.github.com>
meyfa
added a commit
that referenced
this pull request
Apr 16, 2024
This is a backport of PR #17 to the v2.x release branch. Co-authored-by: Ben Thomson <15900351+bennothommo@users.noreply.github.com>
meyfa
added a commit
that referenced
this pull request
Apr 16, 2024
This is a backport of PR #17 to the v3.x release branch. Co-authored-by: Ben Thomson <15900351+bennothommo@users.noreply.github.com>
meyfa
added a commit
that referenced
this pull request
Apr 16, 2024
This is a backport of PR #17 to the v2.x release branch. Co-authored-by: Ben Thomson <15900351+bennothommo@users.noreply.github.com>
meyfa
added a commit
that referenced
this pull request
Apr 16, 2024
This is a backport of PR #17 to the v3.x release branch. Co-authored-by: Ben Thomson <15900351+bennothommo@users.noreply.github.com>
|
Released as v4.1.0 🎉 - and backported to v3.1.0, v2.2.0, v1.3.0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #16, this adds the ability to define calcuators for determining the difference between two images at given pixel co-ordinates. It maintains backwards compatibility by using the current method of pixel difference calculation and adding an additional optional parameter to the
assertSimilarGDandassertNotSimilarGDmethods.Users of this library will be able to define custom calculation methods by implementing the
AssertGD\DiffCalculatorinterface and providing an instance of the custom calculator as the 5th parameter to the above methods.It should hopefully be written in a way that it can be backported to older versions of this library. Happy to change the naming if there are better alternatives.