Modified for PHPUnit 10 #10
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meyfa
requested changes
Sep 8, 2023
There was a problem hiding this comment.
Thanks a lot for the contribution!
CI tests are currently failing since PHPUnit 10 requires PHP v8.1 or later. Can you please update .github/workflows/main.yml to run with PHP versions 8.1 and 8.2 instead of the current list?
Since this is a breaking change, I will have to release it as phpunit-assert-gd 4.0.0. Can you also update README.md to include a row in the compatibility table for this? I think it should read:
| AssertGD version | Supported PHP version | Supported PHPUnit version |
| :--------------- | :-------------------- | :------------------------ |
| 4.* | >= 8.1 | 10.1 and later |
| 3.* | >= 7.3 | 9 |
| 2.* | >= 7.2 | 8 |
| 1.* | >= 5.3.3 | 4.8.36 - 6.5.0 |
|
I have applied your suggested fix, and updated the README. |
meyfa
approved these changes
Sep 14, 2023
|
v4.0.0 is released 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I needed a version of phpunit-assert-gd for use with PHPUnit 10, so I created this PR. Only composer.json and phpunit.xml needed changes, no other files required changes.