Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/type #129

Merged
merged 3 commits into from
May 10, 2022
Merged

Fix/type #129

merged 3 commits into from
May 10, 2022

Conversation

kylebaron
Copy link
Contributor

@kylebaron kylebaron commented May 9, 2022 •
edited
Loading

Summary

  • There was logic in ys_load() to assume character type if values was character
  • I'm not crazy about this right now but keeping it
  • The change is to NOT do this when the user does pass the type

E.g.

STUDY: 
  values: 
  - "101"
  - "201"
  type: "integer"

The type in this case should be integer

Also adding an internal file to find out the max story and test number.

@kylebaron kylebaron requested a review from KatherineKayMRG May 10, 2022 12:47
KatherineKayMRG
KatherineKayMRG approved these changes May 10, 2022
View reviewed changes
Copy link
Contributor

@KatherineKayMRG KatherineKayMRG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me

@kylebaron kylebaron merged commit 2f3250b into develop May 10, 2022
@kylebaron kylebaron deleted the fix/type branch May 10, 2022 15:30
@kylebaron kylebaron linked an issue May 10, 2022 that may be closed by this pull request
Don't change type based on input values #128
Closed
@kylebaron kylebaron mentioned this pull request May 10, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KatherineKayMRG KatherineKayMRG KatherineKayMRG approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Don't change type based on input values
2 participants
@kylebaron @KatherineKayMRG