Check spec for duplicate blocks and allow multiple $PLUGIN #1238
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kylebaron
changed the title
kyleam
approved these changes
Sep 25, 2024
kylebaron
commented
Sep 25, 2024
| @@ -82,6 +82,10 @@ block_list <- c("ENV", "PROB", "PARAM", "INIT", | |||
| "PREAMBLE", "PRED", "BLOCK", "TRANSIT", "YAML", "NMEXT", | |||
| "INPUT", "EVENT") | |||
|
|
|||
| block_list_single <- c("MAIN", "SET", "GLOBAL", "PREAMBLE", "PRED", "PKMODEL", | |||
| "ENV", "CMTN", "INCLUDE", "NAMESPACE", "BLOCK", | |||
| "TRANSIT", "YAML", "EVENT") | |||
There was a problem hiding this comment.
Added EVENT here after merging #1230
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds clarity around where we do and do not allow multiple blocks, adding tests for places where multiples aren't allowed.
We also now allow multiple $PLUGIN blocks. I don't anticipate this getting used a lot, but allowing multiples here, I think, adds clarity to the list of blocks where we don't allow multiples.
Note: we'll have to add $EVENT to the list where we don't allow multiples when that PR comes through.
#1204