Replace num_cpus::get with std::thread::available_parallelism #500
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tobz
added
C-util
tobz
pushed a commit
that referenced
this pull request
Sep 21, 2024
Signed-off-by: Toby Lawrence <toby@nuclearfurnace.com>
|
Released as part of Thanks again for your contribution! |
tobz
removed
the
S-awaiting-release
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
std::thread::available_parallelism was stabilized in rust 1.59, so there should be no problem in using it in this crate with an MSRV of 1.70
To remain consistent with the existing usage of
num_cpus::getwe default to a value of 1 if info on parallelism is inaccessible for whatever reason.The old implementation did a
std::cmp::max(1, ..)but that was not needed with num_cpus since it was documented to return a max of 1, and its not needed now since we handle an error by using 1.