Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OpenAPI 3.1 references should use #/components/schemas/... references instead of #/definitions/... #616

Closed
opqdonut opened this issue May 2, 2023 · 2 comments
Closed

OpenAPI 3.1 references should use #/components/schemas/... references instead of #/definitions/... #616

opqdonut opened this issue May 2, 2023 · 2 comments

Comments

@opqdonut
Copy link
Member

opqdonut commented May 2, 2023

#589 implements top-level :definitions for swagger specs.

However for OpenAPI 3.1 the refs should actually be #/components/schemas/...

https://spec.openapis.org/oas/v3.1.0#componentsObject

This will require a bit of work since swagger & json-schema use "#/definitions/...", so we want to rewrite those just for OpenAPI.
@opqdonut
Copy link
Member Author

opqdonut commented May 2, 2023

We could maybe use options to parameterise the $ref prefix in malli.json-schema.

@opqdonut opqdonut mentioned this issue Sep 7, 2023
Closed
@aviflax aviflax mentioned this issue Feb 29, 2024
Closed
@opqdonut opqdonut mentioned this issue Apr 19, 2024
Closed
opqdonut added a commit to metosin/malli that referenced this issue Apr 19, 2024
@opqdonut
feat: allow changing prefix of $refs vis ::definitions-path
c57a9cf 
needed for metosin/reitit#616
opqdonut added a commit to metosin/malli that referenced this issue Apr 19, 2024
@opqdonut
feat: allow changing prefix of json-schema $refs
f2c963a 
... via option :malli.json-schema/definitions-path

needed for metosin/reitit#616
This was referenced Apr 19, 2024
Merged
Merged
@opqdonut
Copy link
Member Author

The malli part of this is in #673

@opqdonut opqdonut mentioned this issue Apr 22, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@opqdonut