-
Notifications
You must be signed in to change notification settings - Fork 215
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove non-root swagger definitions #900
Remove non-root swagger definitions #900
Conversation
I removed all of the trailing commas in the swagger-test data in 26bda9b, but let me know if you'd rather I not do that. I was having to remove the ones from the deleted non-root definitions in the test expectations and decided it might be better to just clean it all up in one commit first. |
The one failing test also failed before my changes. |
Thanks for removing the commas in a separate commit! All tests seem to pass now. The failures were caused by a clojars outage, but now all the deps downloaded fine and the tests passed as well. I have a nagging thought that the |
Ok, we only need the top-level |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll merge this later today
OK, and now with this merged reitit-malli's test expectations need to be updated, at least. I'll |
As per discussion in metosin/reitit#589 (comment) this removes the non-root
:definitions
from the swagger output.