Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: properly compose interceptors in :map-of json-transformer #849

Merged
merged 2 commits into from
Feb 8, 2023
Merged

fix: properly compose interceptors in :map-of json-transformer #849

merged 2 commits into from
Feb 8, 2023

Conversation

opqdonut
Copy link
Member

@opqdonut opqdonut commented Feb 8, 2023

fixes #819

@opqdonut opqdonut mentioned this pull request Feb 8, 2023
Closed
@opqdonut
feat: don't touch invalid :map-of keys in json-transformer
09ad217 
Previously, json-transformer would always decode map keys to strings,
even if the string could not be decoded to the target type.

See metosin#819 (comment)
@ikitommi ikitommi merged commit a87b424 into metosin:master Feb 8, 2023
@ikitommi
Copy link
Member

ikitommi commented Feb 8, 2023

👍

@opqdonut opqdonut deleted the fix/map-of-decode-819 branch February 10, 2023 07:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Failure to decode :enums having keywords
2 participants
@opqdonut @ikitommi